Arch Linux User Repository

That commit id is the latest to the master branch, so I'd hazard a guess that the source array (specifically ?signed#commit=79ff7796e5) isn't being parsed correctly for some reason, effectively meaning you're building palemoon-git rather than the stable version. No idea why that's happening, but I'd guess either yaourt bug (it's ancient and abandoned, don't use it) or you have a reaaaaally old makepkg version kicking about.

yaourt? Did you try just with

git clone https://aur.archlinux.org/palemoon.git
cd palemoon
makepkg

?

@WorMzy i'm getting a different commit

commit bf093ea79550c71889832eada5f6d7067574feec

not sure why though. i'm using a clean "yaourt -G palemoon" into a clean/new directory and PKGBUILD clearly shows _commit=79ff7796e5

Then you're checking out the wrong commit of the Pale-Moon repo somehow. What does git show -q from inside $srcdir/Pale-Moon show? Should show:

commit 79ff7796e598775f30e00ec251e5c094e31ebe94 (HEAD -> makepkg, tag: 29.0.0_Release, tag: 29.0.0_RC2, origin/release)
Author: Moonchild <moonchild@palemoon.org>                    
Date:   Sat Jan 30 11:15:07 2021 +0000
    Update back-end branch pointer to UXP/release with BB fix.

(excuse formatting, using termux on phone)

@WorMzy UXP/dom/html/HTMLMenuItemElement.cpp is correct, but Pale-Moon/platform/dom/html/HTMLMenuItemElement.cpp is incorrect.

@WorMzy I'm getting:

Submodule path 'platform': checked out 'e1daeef18312a0cb17eda6bed7f363d8748ed4a3'

...and that's with a clean directory to start.

What does prepare() say? Should read:

==> Starting prepare()...
Submodule 'platform' (https://repo.palemoon.org/MoonchildProductions/UXP) registered for path 'platform'
Cloning into '/build/palemoon/src/Pale-Moon/platform'...
done.
Submodule path 'platform': checked out '304496d4ab61496a43d9d42cf8deb7811d772fe2'

@micwoj92 are we getting the wrong UXP commit?

@micwoj92 hm. yeah, i see that. and yet for some reason it's not.

should be:

nsGenericHTMLElement*
NS_NewHTMLMenuItemElement(already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo,
                          mozilla::dom::FromParser aFromParser) {
  if (mozilla::Preferences::GetBool("dom.menuitem.enabled")) {
    return new mozilla::dom::HTMLMenuItemElement(nodeInfo, aFromParser);
  } else {
    return new mozilla::dom::HTMLUnknownElement(nodeInfo);
  }
}

but is still:

nsGenericHTMLElement*
NS_NewHTMLMenuItemElement(already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo,
                          mozilla::dom::FromParser aFromParser) {
  RefPtr<mozilla::dom::NodeInfo> nodeInfo(aNodeInfo);
  if (mozilla::Preferences::GetBool("dom.menuitem.enabled")) {
    return new mozilla::dom::HTMLMenuItemElement(nodeInfo.forget(), aFromParser);
  } else {
    return new mozilla::dom::HTMLUnknownElement(nodeInfo.forget());
  }
}

@jghodd that commit should be included

https://repo.palemoon.org/MoonchildProductions/Pale-Moon/commit/79ff7796e598775f30e00ec251e5c094e31ebe94