As an extension to what @eclairevoyant already said, the submodules should be specified in the sources
array and cloned from local copies, also as per Archwiki suggestions. As it is you are forcing anyone building the package to re-download the full repositories of all the submodules each time they rebuild the package. Also, if a submodule repo is a fork of some other repo, the destination directory in the source array should be named in something that won't conflict with the upstream repo, since makepkg
supports global source directories through SRCDEST
.
Since this can be a chore for packages where upstream hates distro packaging and change submodules regularly without the ability to easily use system packages, you could at least instruct git submodule
to do shallow clones, saving on both space and time.
As a last note, the errors in the PKGBUILD are too numerous to mention all of them. Please consult the relevant Archwiki articles, PKGBUILDs from the official repositories. The PKGBUILD is broken as it is.
Some other examples:
The cheats download at post_install
(can't those be part of the sources?) as they as they won't be removed when the package is uninstalled, because they are not part of it. Also using sudo
, is pointless as your permissions are already elevated when installing a package.
The version SHOULD NOT start with v
, it has to be removed. Take a look at /usr/share/pacman/PKGBUILD-vcs.proton
the install script is historically named $pkgname.install
And since upstream is being difficult about downstream packaging, it might be worth exploring installing it in /var/games
or /opt
as whole and giving access to the users through the games
group https://wiki.archlinux.org/title/users_and_groups#User_groups
Pinned Comments
weirdbeard commented on 2024-08-17 03:40 (UTC)
https://github.com/PCSX2/pcsx2/pull/11632
This package now enables Cmake Package mode proper. PCSX2 will here on, be installed in the package standard folders /usr/bin, /usr/share, /usr/lib. Following the XDG standard pcsx2's config files remain in .config/PCSX2
In order to ensure a proper and clean upgrade. Uninstall this package COMPLETELY and clear cache before reinstalling.