Can I have co-maintainer on this so I can help push the changes required to get rid of the generic tests in the package?
Search Criteria
Package Details: python-protonvpn-nm-lib 3.16.0-1
Git Clone URL: | https://aur.archlinux.org/python-protonvpn-nm-lib.git (read-only, click to copy) |
---|---|
Package Base: | python-protonvpn-nm-lib |
Description: | Official ProtonVPN NetworkManager Library, maintained by the ProtonVPN team. |
Upstream URL: | https://github.com/ProtonVPN |
Licenses: | GPL3 |
Groups: | ProtonVPN |
Conflicts: | protonvpn-cli, protonvpn-gui |
Submitter: | protontechag |
Maintainer: | protontechag (calexandru2018, jllaneras) |
Last Packager: | calexandru2018 |
Votes: | 41 |
Popularity: | 2.36 |
First Submitted: | 2021-05-28 15:51 (UTC) |
Last Updated: | 2023-08-01 11:43 (UTC) |
Dependencies (16)
- dbus (dbus-gitAUR, dbus-x11-gitAUR, dbus-selinuxAUR)
- libnm (libnm-gitAUR, libnm-iwdAUR)
- libsecret
- networkmanager (networkmanager-gitAUR, networkmanager-iwdAUR)
- networkmanager-openvpn (networkmanager-openvpn-gitAUR, networkmanager-openvpn-gtk2AUR)
- openvpn (openvpn-gitAUR, openvpn-mbedtlsAUR)
- python-dbus (dbus-python)
- python-distro
- python-gobject (python-gobject-gitAUR)
- python-jinja
- python-keyring
- python-proton-clientAUR
- python-pyxdg
- python-systemd
- xdg-utils (busking-gitAUR, xdg-utils-slockAUR, mimiAUR, mimi-gitAUR, xdg-utils-handlrAUR, openerAUR, xdg-utils-betterlockscreenAUR, mimejs-gitAUR, xdg-utils-mimeoAUR)
- python-setuptools (make)
Required by (2)
Sources (1)
txtsd commented on 2024-04-14 06:22 (UTC)
xiota commented on 2023-11-03 15:01 (UTC) (edited on 2023-11-03 15:03 (UTC) by xiota)
@evorster Suggest reporting the issue to any other packages you find. The fix is simple and takes only a few minutes for maintainers to apply. You should also attempt to report the issue upstream to the package source. Search old issues first, in case it has already been reported. If so, add a comment or emoji or something to let developers know you are also affected by the issue.
If you are unable to edit the PKGBUILD for your own personal builds, pacman
has an --overwrite
option.
evorster commented on 2023-11-03 14:15 (UTC)
This package conflicts with espeak-phonemizer, exactly because of those generic non-package specific files.
dreieck commented on 2023-08-03 12:13 (UTC)
A quick fix to fix the generic files in /usr/lib/python3.11/site-packages/tests/
issue (↗ patch to PKGBUILD
):
--- PKGBUILD.org 2023-08-03 14:08:53.850523975 +0200
+++ PKGBUILD 2023-08-03 14:12:37.710539349 +0200
@@ -12,5 +12,5 @@
depends=("python-proton-client" "networkmanager" "networkmanager-openvpn" "openvpn" "libnm" "dbus" "libsecret" "python-pyxdg" "python-keyring" "python-jinja" "python-distro" "python-dbus" "python-systemd" "xdg-utils" "python-gobject")
conflicts=("protonvpn-cli<3.12.0" "protonvpn-gui<1.9.0")
-makedepends=("python-setuptools")
+makedepends=("python-build" "python-installer" "python-wheel")
source=("https://github.com/ProtonVPN/protonvpn-nm-lib/archive/refs/tags/$pkgver.tar.gz")
sha256sums=('9edf705d435b65d54c7224d4bc853b4b7e02a228a57264083b2776b8424aee36')
@@ -19,9 +19,13 @@
build() {
cd "$_gitpkgname-$pkgver"
- python setup.py build
+
+ python -m build --wheel --no-isolation
}
package() {
cd "$_gitpkgname-$pkgver"
- python setup.py install --root="$pkgdir" --optimize=1
+
+ _pythonversion="$(python --version | awk '{print $2}' | awk -F. '{print $1"."$2}')"
+ python -m installer --destdir="$pkgdir" --compile-bytecode=2 dist/*.whl
+ rm -Rfv "${pkgdir}/usr/lib/python${_pythonversion}/site-packages/tests"
}
It might be possible to do it better.
Please review and apply.
Thanks for maintaining!
dreieck commented on 2023-08-02 09:21 (UTC) (edited on 2023-08-02 09:27 (UTC) by dreieck)
This package installes generic, non-package specific, files, which makes it likely to conflict with other packages:
error: failed to commit transaction (conflicting files)
python-protonvpn-nm-lib: /usr/lib/python3.11/site-packages/tests/__init__.py exists in filesystem (owned by kicost-git)
python-protonvpn-nm-lib: /usr/lib/python3.11/site-packages/tests/__pycache__/__init__.cpython-311.opt-1.pyc exists in filesystem (owned by kicost-git)
python-protonvpn-nm-lib: /usr/lib/python3.11/site-packages/tests/__pycache__/__init__.cpython-311.pyc exists in filesystem (owned by kicost-git)
Errors occurred, no packages were upgraded.
Please use pacman -Ql python-protonvpn-nm-lib
to find out the complete lists of such generic files, and make sure they will not be installed.
I doubt that anything under /usr/lib/python3.11/site-packages/tests/
is needed at all. Please check if it can be omitted or moved into a python-protonvpn-nm
specific directory.
Regards and thanks for maintaining!
jsimon0 commented on 2022-12-06 14:23 (UTC) (edited on 2022-12-06 19:12 (UTC) by jsimon0)
ETA: Fixed by blowing away cache and config directories, uninstalling and reinstalling, then logging in from shell with protonvpn-cli login <user>
Anybody else having trouble signing in? I"m getting this in the log:
2022-12-06 14:21:18,693 — utilities.py — INFO — ensure_internet_connection_is_available:20 — Checking for internet connectivity
2022-12-06 14:21:18,883 — linuxkeyring.py — INFO — __delitem__:52 — Delete key UserData
2022-12-06 14:21:18,885 — linuxkeyring.py — ERROR — __delitem__:67 — KeyringDataNotFound: Password not found
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/protonvpn_nm_lib/core/keyring/linuxkeyring.py", line 58, in __delitem__
self.__keyring_backend.delete_password(self.__keyring_service, key)
File "/usr/lib/python3.10/site-packages/keyring/backends/kwallet.py", line 151, in delete_password
raise PasswordDeleteError("Password not found")
keyring.errors.PasswordDeleteError: Password not found
2022-12-06 14:21:18,885 — linuxkeyring.py — INFO — __delitem__:52 — Delete key SessionData
2022-12-06 14:21:18,887 — linuxkeyring.py — ERROR — __delitem__:67 — KeyringDataNotFound: Password not found
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/protonvpn_nm_lib/core/keyring/linuxkeyring.py", line 58, in __delitem__
self.__keyring_backend.delete_password(self.__keyring_service, key)
File "/usr/lib/python3.10/site-packages/keyring/backends/kwallet.py", line 151, in delete_password
raise PasswordDeleteError("Password not found")
keyring.errors.PasswordDeleteError: Password not found
2022-12-06 14:21:18,887 — linuxkeyring.py — INFO — __delitem__:52 — Delete key ProtonUser
2022-12-06 14:21:18,888 — linuxkeyring.py — ERROR — __delitem__:67 — KeyringDataNotFound: Password not found
Traceback (most recent call last):
File "/usr/lib/python3.10/site-packages/protonvpn_nm_lib/core/keyring/linuxkeyring.py", line 58, in __delitem__
self.__keyring_backend.delete_password(self.__keyring_service, key)
File "/usr/lib/python3.10/site-packages/keyring/backends/kwallet.py", line 151, in delete_password
raise PasswordDeleteError("Password not found")
keyring.errors.PasswordDeleteError: Password not found
2022-12-06 14:21:18,888 — session.py — INFO — logout:368 — Cleared keyring session
2022-12-06 14:21:18,888 — session.py — INFO — logout:376 — Cleared user data
2022-12-06 14:21:18,889 — session.py — INFO — logout:379 — Cleared local cache variables
2022-12-06 14:21:18,889 — session.py — INFO — logout:384 — Attempting to logout via API
2022-12-06 14:21:18,889 — session.py — INFO — logout:391 — Remove cache files
rokam commented on 2022-11-15 10:35 (UTC)
Traceback (most recent call last):
File "/home/oooo/.cache/yay/python-protonvpn-nm-lib/src/protonvpn-nm-lib-3.14.0/setup.py", line 5, in <module>
from protonvpn_nm_lib.constants import APP_VERSION
File "/home/oooo/.cache/yay/python-protonvpn-nm-lib/src/protonvpn-nm-lib-3.14.0/protonvpn_nm_lib/constants.py", line 8, in <module>
from xdg import BaseDirectory
ImportError: cannot import name 'BaseDirectory' from 'xdg' (/home/oooo/.local/lib/python3.10/site-packages/xdg/__init__.py)
morealaz commented on 2022-10-08 08:38 (UTC)
Please rename source
line to rename downloaded source file to include pkgname
and pkgver
in its name:
source=("${pkgname}-${pkgver}.tar.gz::https://github.com/ProtonVPN/protonvpn-nm-lib/archive/refs/tags/$pkgver.tar.gz")
10b2 commented on 2022-09-17 07:26 (UTC)
The current source package contains linux-cli package instead of the nm-lib package.
PKGBUILD: line 20: cd: protonvpn-nm-lib-3.13.0: No such file or directory
Wires got crossed somewhere. maybe automation.
iyanmv commented on 2022-05-27 15:00 (UTC)
I just sent you an email, but I write it here as well.
Please, consider removing the conflict array. I think it doesn't make sense to include both the version requirements in the depend arrays of protonvpn-gui and protonvpn-cli, and the conflict array here as well.
Pinned Comments
XxTriviumxX commented on 2022-05-25 17:08 (UTC) (edited on 2022-05-28 13:01 (UTC) by XxTriviumxX)
a solution was found by the user theoldfellow here:
https://aur.archlinux.org/packages/protonvpn-cli
solution for paru users: