Package Details: spotdl 4.2.10-1

Git Clone URL: https://aur.archlinux.org/spotdl.git (read-only, click to copy)
Package Base: spotdl
Description: Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
Upstream URL: https://github.com/spotDL/spotify-downloader
Keywords: download-music mp3 music playlists song song-lyrics spotify youtube-music
Licenses: MIT
Conflicts: python-spotdl
Provides: python-spotdl
Replaces: python-spotdl
Submitter: zoorat
Maintainer: zoorat (pekkarr, aminvakil)
Last Packager: aminvakil
Votes: 25
Popularity: 0.85
First Submitted: 2024-03-31 19:44 (UTC)
Last Updated: 2024-11-19 09:05 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »

pekkarr commented on 2024-03-31 14:21 (UTC)

@zoorat Please don't use PyPI as the source, see Arch Linux RFC 20. And yes, upstream changed the v4.2.5 git tag from c646615 to bd38845 which is why the checksum changed.

By the way, I agree with @xiota, this package should be renamed to spotdl. This could be done by submitting it with the new name to AUR and then submitting a merge request to merge python-spotdl into spotdl.

zoorat commented on 2024-03-31 14:08 (UTC)

@gesh thanks for the report

the reason why the b2sum is wrong is because they published v4.2.5 twice. (just checked my emails) most probably because they had some build error before. i am updating it now.

and all tarballs you tested failed because i changed the source from pypi.io to github for upgrading to the 4.2.5 version.

gesh commented on 2024-03-31 12:57 (UTC)

b2sums incorrectly updated, and it is unclear what release it was generated from -- testing with the tarballs for 4.2.{3,4,5} all yield different b2sums.

Also, please prefix the source tarball with $pkgname -- some of us combine source caches, and it is nice to have some indication of what package pulled in what source.

aminvakil commented on 2023-11-12 14:56 (UTC) (edited on 2023-11-12 14:57 (UTC) by aminvakil)

I agree with @pekkarr about Makefile, let's keep things simple.

I use a bash script for myself for bumping packages which it's local and https://github.com/aminvakil/aur to test changes and build packages nightly for packages I maintain and co-maintain (which I invite you to use in case you wanted a really clean build and / or propose changes or good to haves in it).

Also aurpublish, locally and on github actions.

zoorat commented on 2023-11-12 12:00 (UTC)

@pekkarr i was reading https://www.shellcheck.net/wiki/SC2164 and totally forgot about the makepkg hook. sorry. my bad.

@aminvakil i thought it would be a good quality of life change... removed it.

about Makefile, i saw many packages with them. i got that it won't be useful for users to review, so i added a comment. it's not that big to understand it's a script for maintainers. and i can see people without package manager can use it...

if you guys strongly think it is bad thing then i will remove it.

pekkarr commented on 2023-11-12 10:43 (UTC)

I agree with @aminvakil, the changelog is unnecessary in the package. Very few official packages use that pacman feature, and users can find the changelog on upstream Github repository anyways.

Also, in my opinion the AUR git repository is wrong place for a Makefile for maintaining the PKGBUILD. It adds unnecessary complexity that users need to review when they install the package, while being completely useless for users. Thus, it should not be committed to the AUR.

Using exit inside PKGBUILD is also wrong: it causes the whole makepkg process to exit without running hooks set by makepkg that print A failure occurred in .... Makepkg runs the functions in an environment where a non-zero exit status from a command already terminates the function, so adding || exit or similar to commands is also unnecessary.

By the way, using cd would be simpler than pushd. There's no need to change the working directory back to the original after each function. pushd and popd also unnecessarily print the directory stack after each invocation.

The GIT_DIR=. workaround is also unnecessary now, since that python-poetry bug has been fixed.

aminvakil commented on 2023-11-12 09:37 (UTC)

Why should we have changelog.md in this repository? Do you want to keep this updated on every release?

zoorat commented on 2023-11-12 04:57 (UTC)

hey,

i added the changelog. use pacman -Qc python-spotdl to check it, and linted PKGBUILD based on shellcheck, also added a Makefile to make life easier :)

and thanks @aminvakil, @AlexisBRENON and @txtsd for keep this package uptodate.

txtsd commented on 2023-11-03 04:07 (UTC)

@ioan patch is included in base-devel which should be installed if you're building anything on Arch.

« First ‹ Previous 1 2 3 4 5 6 7 8 9 Next › Last »