Arch Linux User Repository

Editing PKGBUILD is no-longer necessary since tests execute fine and problem was fixed upstream

Since last commits dino fails to build, solution is temporarily edit PKGBUILD:
- Remove --with-tests in the build step
- Delete the check() function altogether

Problem is known upstream and already fixed but not yet released

Thanks @NicoHood, I was on hollidays and didn't have a computer with me.

I added also ninja as makedepends, it's not mandatory but it's recommended in the readme

You need to add glibc-networking and libsoup as new dependency:
https://github.com/dino/dino/issues/114#issuecomment-320436120
https://github.com/dino/dino/commit/ea174ab632ced082eb0f1c51cea1bc9dc5c7c89e#commitcomment-23496697

The version bump is discussed here:
https://wiki.archlinux.org/index.php/Talk:VCS_package_guidelines#Warn_against_trivial_pkgver_bumps

NicoHood:
Hi,

> You do not need to update the package on a version bump unless the build procedure does not change.

I couldn't find this nor in the guidelines nor in the ml archives, can you point me somewhere? I remember, not clearly though, a discussion in the ML on this topic and it seemed to me there was no consensus.

>This produces lots of git entries and you cannot find real changes.

As dino is evolving rapidly new features or fixes which are important happens so I do not agree on this point.

>People need to manually update their package. AUR helpers also provide switches to check for -git package updates.

This is true but I find particularly annoying to re-download the whole repo just to discover nothing changed. If me, as the co-mantainer, have time to update the pkgversion when something relevant changes, providing details [1], I think it is no damage for anyone. Correct me if I'm wrong please :)

In the aur helper I'm using there's a difference between checking for new versions of packages in the aur and checking for updates for devel packages.
Usually I check for updates also for packages in the aur, not so often I check if any new commit appear in any of the -devel packages I installed as some of them are quite big projects.

As developers of dino will decide time for a release has come I'll create a non-devel package for dino. If you still want to bring it into community I'll be happy. Still I think I'll keep updating the -git version in the aur if it's not going against any guideline.

[1]https://aur.archlinux.org/cgit/aur.git/log/?h=dino-git&showmsg=1

svalo: Thanks for applying the changes.

You do not need to update the package on a version bump unless the build procedure does not change. This produces lots of git entries and you cannot find real changes. People need to manually update their package. AUR helpers also provide switches to check for -git package updates.

Hi NicoHood,
> * license needs to be GPL3 not GPLv3
Thanks, fixed

> * Please use sha512sums, even though its skipped. It shows other users the importance of secure hashes
Did that even though, as you stated, it's skipped being a VCS package.

> * Please fix the indention. Always use spaces as tabs, 2 or 4
Tabs are now 4 spaces

> The rest looks okay to me. Nice package :)
Thanks it's a common effort with seppia

Hi svalo.
I have some improvements for packaging dino on arch:

* license needs to be GPL3 not GPLv3
* provides and conflicts need to be 'dino' not 'dino-git'; edit: ups. dino is something completely different. Maybe those need to be renamed in the near future. Keep it as it is then.
* Please use sha512sums, even though its skipped. It shows other users the importance of secure hashes
* Please fix the indention. Always use spaces as tabs, 2 or 4

The rest looks okay to me. Nice package :)

No more crashes while sending OMEMO messages