I think libsmall
needs to be added to the submodules unpacked in prepare()
, viz.
git config submodule.third-party/small.url "$srcdir/small"
[...]
git -c protocol.file.allow=always submodule update \
[...]
third-party/small
Git Clone URL: | https://aur.archlinux.org/transmission-cli-git.git (read-only, click to copy) |
---|---|
Package Base: | transmission-cli-git |
Description: | Fast, easy, and free BitTorrent client (CLI tools and daemon and web client) |
Upstream URL: | https://www.transmissionbt.com/ |
Licenses: | GPL-2.0-or-later |
Conflicts: | transmission-cli |
Provides: | transmission-cli |
Submitter: | lonaowna |
Maintainer: | EndlessEden (cephian, glitsj16) |
Last Packager: | EndlessEden |
Votes: | 6 |
Popularity: | 0.000001 |
First Submitted: | 2018-01-17 23:20 (UTC) |
Last Updated: | 2025-04-30 06:37 (UTC) |
I think libsmall
needs to be added to the submodules unpacked in prepare()
, viz.
git config submodule.third-party/small.url "$srcdir/small"
[...]
git -c protocol.file.allow=always submodule update \
[...]
third-party/small
Will resolve when I get home. Sorry for delay.
Update co-maintainer list @glitsj16 -- you have been added.
(Sorry I dont have any other time right now)
@cephian Did you use the latest revision
of my PKGBUILD? Those libsmall errors should have been fixed in revision 6
. Upstream has a fix for building from git (https://github.com/transmission/transmission/pull/5743) but that isn't merged yet. Feel free to post your errors somewhere and we can have a look what's going on. Also, don't worry about co-maintainership. Although I do appreciate people's comments about it, the main thing for me personally is getting a properly working PKGBUILD out to AUR users.
As a co-maintainer myself (who was added because I fixed something in the comments) I don't seem to have permissions to add another co-maintainer. I would be happy to update the package but glitsj16's fixed PKGBUILD still does not build for me. In particular I seem to get errors building libsmall which complain about uintptr not being defined in src/transmission/third-party/small/include/small/detail/exception/scope_guard.hpp
. I tried to just patch this manually but it still failed at a later stage of compilation. I'm not sure if I have the bandwidth to debug this myself, but if someone helps or posts a PKGBUILD which works on my system I will update this package.
I agree with @yar, @glitsj16 should be the co-maintainer. I had sent a mail to current maintainer on 26 Jun.
tbh when someone shows the initiative glitsj16 has, you should just add them as a co-maintainer
Updated my PKGBUILD referenced in earlier comment to account for upstream's recent commit.
I have a few remarks/questions about this package.
(1) Upstream has a GPL licence, not MIT.
(2) According to the pkgdesc users might expect the web client to be included in this package. But it isn't, due to the configuration. There's no trace of 'ENABLE_WEB' in upstream's CMakeLists.txt, so that can be removed in the build() function.
(3) Potential conflict/confusion by having libutp in depends yet -DUSE_SYSTEM_UTP=OFF in configuration.
(4) publicsuffix-list (in makedepends) is already there due to libpsl requiring it.
(5) Why the need for -DINSTALL_LIB=ON? This relates to libtransmission if I'm correct, and that is not needed here in my opinion.
(6) Referencing of the third-party git repo's in the source array is superfluous.
(7) Use ninja instead of make.
Here's a PKGBUILD that implements the above as example. Feel free to use whatever you deem relevant.
I cannot reproduce rekman's comment below, the package seems to build fine for me on clang 15.0.7 on an updated x86_64 arch system. If this is a problem for anyone else let me know.
Pinned Comments
EndlessEden commented on 2025-04-30 06:42 (UTC)
@afader -- I just built in a clean chroot. Sounds like a issue either with your system or your chroot. tested with a knoppix ISO to verify it functions as intended. If you can create a dump and link to it here, i can take a look.
-- Updated pkgver, updated the maintainers list (@glitsj16 & @cephian | if you want to be listed as a maintainer instead of contributors in pkgbuild, please update your sections in it. Thanks.)
Trying to be more active, apologies for the long hiatus.