Arch Linux User Repository

@marco44 I use lensfun-git associated with the master branch of Darktable for several months and I have the build issue since 3 days.This is the only way for the lens correction module to recognize my objective profiles obtained with lensfun-convert-lcp from adobe profiles for my lenses that are not yet supported by lensfun. No build issue with ubuntu

@ctouze: yup, that's been the case for a very long while. As far as I know, lensfun hasn't released a new version in years, and the HEAD version has these prototypes changes. So darktable doesn't build for these.

You probably don't need lensfun-git anyway. If that's for new lens support, just use the regular lensfun package and run lensfun-update-data

Build issue with lensfun-git In file included from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc: In function ‘lfModifier get_modifier(int, int, int, const dt_iop_lensfun_data_t, int)’: /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:359:60: error: no matching function for call to ‘lfModifier::lfModifier(const float&, int&, int&, lfPixelFormat, const int&)’ 359 | mod = new lfModifier(d->crop, w, h, LF_PF_F32, d->inverse); | ^ In file included from /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:48, from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /usr/include/lensfun/lensfun.h:2486:5: note: candidate: ‘lfModifier::lfModifier(const lfLens, float, float, int, int, lfPixelFormat, bool)’ 2486 | lfModifier (const lfLens lens, float imgfocal, float imgcrop, int imgwidth, int imgheight, lfPixelFormat pixel_format, bool reverse = false); | ^~~~~~~~~~ /usr/include/lensfun/lensfun.h:2486:5: note: candidate expects 7 arguments, 5 provided /usr/include/lensfun/lensfun.h:2372:16: note: candidate: ‘lfModifier::lfModifier(const lfLens, float, int, int)’ 2372 | DEPRECATED lfModifier (const lfLens lens, float crop, int width, int height); | ^~~~~~~~~~ /usr/include/lensfun/lensfun.h:2372:16: note: candidate expects 4 arguments, 5 provided /usr/include/lensfun/lensfun.h:2348:18: note: candidate: ‘lfModifier::lfModifier(const lfModifier&)’ 2348 | struct LF_EXPORT lfModifier | ^~~~~~~~~~ /usr/include/lensfun/lensfun.h:2348:18: note: candidate expects 1 argument, 5 provided In file included from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:361:71: error: no matching function for call to ‘lfModifier::EnableDistortionCorrection(lfLens const&, const float&)’ 361 | mods_done_tmp |= mod->EnableDistortionCorrection(d->lens, d->focal); | ^ In file included from /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:48, from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /usr/include/lensfun/lensfun.h:2499:9: note: candidate: ‘int lfModifier::EnableDistortionCorrection(const lfLensCalibDistortion&)’ 2499 | int EnableDistortionCorrection (const lfLensCalibDistortion& lcd); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/lensfun/lensfun.h:2499:9: note: candidate expects 1 argument, 2 provided /usr/include/lensfun/lensfun.h:2510:9: note: candidate: ‘int lfModifier::EnableDistortionCorrection()’ 2510 | int EnableDistortionCorrection (); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/lensfun/lensfun.h:2510:9: note: candidate expects 0 arguments, 2 provided In file included from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:363:86: error: no matching function for call to ‘lfModifier::EnableProjectionTransform(lfLens* const&, const float&, const lfLensType&)’ 363 | ->EnableProjectionTransform(d->lens, d->focal, d->target_geom); | ^

In file included from /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:48, from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /usr/include/lensfun/lensfun.h:2570:9: note: candidate: ‘int lfModifier::EnableProjectionTransform(lfLensType)’ 2570 | int EnableProjectionTransform (lfLensType target_projection); | ^~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/lensfun/lensfun.h:2570:9: note: candidate expects 1 argument, 3 provided In file included from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:369:69: error: no matching function for call to ‘lfModifier::EnableTCACorrection(lfLens const&, const float&)’ 369 | else mods_done_tmp |= mod->EnableTCACorrection(d->lens, d->focal); | ^ In file included from /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:48, from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /usr/include/lensfun/lensfun.h:2520:9: note: candidate: ‘int lfModifier::EnableTCACorrection(const lfLensCalibTCA&)’ 2520 | int EnableTCACorrection (const lfLensCalibTCA& lctca); | ^~~~~~~~~~~~~~~~~~~ /usr/include/lensfun/lensfun.h:2520:9: note: candidate expects 1 argument, 2 provided /usr/include/lensfun/lensfun.h:2531:9: note: candidate: ‘int lfModifier::EnableTCACorrection()’ 2531 | int EnableTCACorrection (); | ^~~~~~~~~~~~~~~~~~~ /usr/include/lensfun/lensfun.h:2531:9: note: candidate expects 0 arguments, 2 provided In file included from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:372:97: error: no matching function for call to ‘lfModifier::EnableVignettingCorrection(lfLens const&, const float&, const float&, const float&)’ 372 | nettingCorrection(d->lens, d->focal, d->aperture, d->distance); | ^

In file included from /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:48, from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /usr/include/lensfun/lensfun.h:2541:9: note: candidate: ‘int lfModifier::EnableVignettingCorrection(const lfLensCalibVignetting&)’ 2541 | int EnableVignettingCorrection (const lfLensCalibVignetting& lcv); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/lensfun/lensfun.h:2541:9: note: candidate expects 1 argument, 4 provided /usr/include/lensfun/lensfun.h:2556:9: note: candidate: ‘int lfModifier::EnableVignettingCorrection(float, float)’ 2556 | int EnableVignettingCorrection (float aperture, float distance); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/lensfun/lensfun.h:2556:9: note: candidate expects 2 arguments, 4 provided In file included from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc: In function ‘void commit_params(dt_iop_module_t, dt_iop_params_t, dt_dev_pixelpipe_t, dt_dev_pixelpipe_iop_t)’: /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:1150:9: error: no match for ‘operator=’ (operand types are ‘lfLensCalibTCA’ and ‘<brace-enclosed initializer list>’) 1150 | }; | ^ In file included from /tmp/trizen-ch/darktable-git/src/darktable/src/iop/lens.cc:48, from /tmp/trizen-ch/darktable-git/src/darktable/build/src/iop/introspection_lens.cc:54: /usr/include/lensfun/lensfun.h:733:8: note: candidate: ‘constexpr lfLensCalibTCA& lfLensCalibTCA::operator=(const lfLensCalibTCA&)’ 733 | struct lfLensCalibTCA | ^~~~~~~~~~~~~~ /usr/include/lensfun/lensfun.h:733:8: note: no known conversion for argument 1 from ‘<brace-enclosed initializer list>’ to ‘const lfLensCalibTCA&’ /usr/include/lensfun/lensfun.h:733:8: note: candidate: ‘constexpr lfLensCalibTCA& lfLensCalibTCA::operator=(lfLensCalibTCA&&)’ /usr/include/lensfun/lensfun.h:733:8: note: no known conversion for argument 1 from ‘<brace-enclosed initializer list>’ to ‘lfLensCalibTCA&&’ make[2]: [src/iop/CMakeFiles/lens.dir/build.make:68: src/iop/CMakeFiles/lens.dir/introspection_lens.cc.o] Error 1 make[1]: [CMakeFiles/Makefile2:4393: src/iop/CMakeFiles/lens.dir/all] Error 2 make: *** [Makefile:152: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... :: Unable to build darktable-git - makepkg exited with code: 4

Yes, cannot build with exiv2 0.27 for now.

The build fails with the following error:

Scanning dependencies of target darktable-curve-tool
[ 66%] Building C object CMakeFiles/darktable-curve-tool.dir/darktable-curve-tool.o
[ 66%] Building CXX object CMakeFiles/darktable-curve-tool.dir/exif-wrapper.o
/home/bjoern/.cache/yay/darktable-git/src/darktable/tools/basecurve/exif-wrapper.cpp: In function ‘int exif_get_ascii_datafield(const char*, const char*, char*, size_t)’:
/home/bjoern/.cache/yay/darktable-git/src/darktable/tools/basecurve/exif-wrapper.cpp:62:17: error: ‘Error’ in namespace ‘Exiv2’ does not name a type
   catch (Exiv2::Error& e)
                 ^~~~~
make[2]: *** [CMakeFiles/darktable-curve-tool.dir/build.make:76: CMakeFiles/darktable-curve-tool.dir/exif-wrapper.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:73: CMakeFiles/darktable-curve-tool.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
Error making: darktable-git

Hi Marc, Of course i would like to help you and archlinux community But i think that i'll need help for my first submission because i have an error 403 when i want to "git push" my modification

The build number in the PKGBUILD is only updated each time I push a new version of this package (it's not the build number you get when you install it). Or I don't understand what you mean (do you mean I'm not getting the commit value right ?

Anyway, if you want to maintain this package, I would gladly let it to you. I've already got quite a few to manage.

Hi, I would like to help you to maintain this PKGBUILD. I'm cofounder of https://darktable.fr and we follow the github repository day by day. Actually, the build number in this PKGBUILD doesn't match to the last commit. If i can help you to push modifications don't hesitate to contect me Regards

https://github.com/darktable-org/darktable/pull/1686 meh, that's all I could have been bothered to do. edit: and it has been merged.

Hi Rinoceros. It appeared with GCC 8.1. Either you directly do a bugreport to the darktable team as you found it before me, or I can do it, as you want :)