| Git Clone URL: | https://aur.archlinux.org/kodi-git.git (read-only, click to copy) |
|---|---|
| Package Base: | kodi-git |
| Description: | Kodi Texturepacker tool (master branch) |
| Upstream URL: | https://kodi.tv |
| Licenses: | GPL2 |
| Conflicts: | kodi-tools-texturepacker |
| Provides: | kodi-tools-texturepacker |
| Submitter: | BlackIkeEagle |
| Maintainer: | graysky |
| Last Packager: | graysky |
| Votes: | 85 |
| Popularity: | 0.001165 |
| First Submitted: | 2014-10-23 06:38 (UTC) |
| Last Updated: | 2024-11-13 19:34 (UTC) |
Fresh clone.
patching file xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemux.cpp
Hunk #1 FAILED at 15.
Hunk #3 succeeded at 48 with fuzz 2.
Hunk #4 FAILED at 67.
2 out of 4 hunks FAILED -- saving rejects to file xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemux.cpp.rej
Also, when building kodi-stable-git, have some java related errors. Had to change makedep to java-runtime<=21. Might also apply to this package.
Checksum of PR is correct and PR is still needed
@graysky @ilikenwf
Thanks for taking up on the FindThreads Issue
Was able to compile by downgrading my build container to https://archive.archlinux.org/repos/2023/09/19/$repo/os/$arch
pacman 6.0.2-7, cmake 3.27.5-1, make 4.4.1-2
@graysky @m10r I brought it up on the actual RFC thread about adding those flags:
https://gitlab.archlinux.org/archlinux/packaging/packages/pacman/-/merge_requests/6#note_171460
Here's my workaround - replace the lines after the configure options:
# makepkg is breaking the -Wl,-z,pack-relative-relocs ldflag for cmake's FindThreads
export LDFLAGS=$(echo "$LDFLAGS" | sed 's/-Wl,-z,pack-relative-relocs//g')
echo "building kodi"
cmake "${_args[@]}" ../"$_gitname"
make
This particular flag, when it works, just makes the resulting binary a little bit smaller and more organized, it isn't really to do with security, so removing it should be fine.
@ilikenwf - recommend you take this to the forum or open a task against pacman.
Just trying to build Kodi 21 RC2 and running into same Error mentioned by ilikenwf concernig:
Could NOT find Threads (missing: Threads_FOUND)
Just wondered if there are allready updates to simplify/fix the build process
Thanks for any Info
Note that the most recent makepkg.conf upgrade adds pack-relative-relocs to the LDFLAGS, and while it should support the flag, cmake can't successfully FindThreads within makepkg, specifically.
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake/Modules/FindThreads.cmake:226 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:166 (find_package)
If I source makepkg.conf and run it outside makepkg and replicate the PKGBUILD build steps by hand in the console, it works...not sure why, would love some help understanding and fixing it though.
For now I have this prior to calling cmake:
# makepkg is breaking the -Wl,-z,pack-relative-relocs ldflag for cmake's FindThreads
export LDFLAGS=$(echo "$LDFLAGS" | sed 's/-Wl,-z,pack-relative-relocs//g')
See my latest post, but removing the flag is effective and acceptable.
Pinned Comments
graysky commented on 2022-06-11 11:49 (UTC)
@laichiaheng - kodi is bound to a specific version of ffmpeg which is generally older than Arch's package. We avoid incompatibilities by using that specific version (ie internal ffmpeg). Recommend that you build kodi in clean chroot. See: https://wiki.archlinux.org/title/DeveloperWiki:Building_in_a_clean_chroot
I wrote a script that automates much of that called clean-chroot-manager offered here in the AUR.