Package Details: polymc 6.1-1

Git Clone URL: https://aur.archlinux.org/polymc.git (read-only, click to copy)
Package Base: polymc
Description: Minecraft launcher with the ability to manage multiple instances
Upstream URL: https://github.com/PolyMC/PolyMC
Licenses: GPL3
Submitter: glorious-yellow
Maintainer: LennyLennington (Kaydax, sperg512)
Last Packager: Kaydax
Votes: 63
Popularity: 0.32
First Submitted: 2022-01-11 20:53 (UTC)
Last Updated: 2024-01-11 19:59 (UTC)

Dependencies (18)

Required by (1)

Sources (1)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 Next › Last »

katt commented on 2022-03-15 16:39 (UTC) (edited on 2022-03-15 16:50 (UTC) by katt)

I cannot for the life of me build this, just getting loads of undefined reference during linking. Log: https://gist.github.com/bdbbef4a7b0783a03f27b33509e13ae8

ah, it's due to LTO: https://github.com/PolyMC/PolyMC/issues/268

Even with LTO disabled (options=(!lto)), it instead fails one of the tests instead... 7/14 Test #7: PackageManifest ..................***Failed 0.01 sec

glorious-yellow commented on 2022-03-12 22:49 (UTC)

Also, did you test that it builds and packages properly before you pushed the commit that changes it to 1.1.0?

It didn't build correctly on my computer, so I then tested it again inside an Arch docker container. It worked inside the container so I assumed that there was an issue with my own setup.

ivan_p commented on 2022-03-12 19:24 (UTC)

Ah, I see... then I'll wait until next update, to check if it still occurs. If it's a one time issue, then it's probably not worth the research.

LennyLennington commented on 2022-03-12 19:17 (UTC) (edited on 2022-03-12 19:17 (UTC) by LennyLennington)

@Ivan_p The problem is something to do with the fact that the submodule changed to use upstream quazip instead of the PolyMC patched quazip that is at https://github.com/PolyMC/quazip, if that helps you find a way to fix it. Thanks for attempting to find a fix if you do get the time.

ivan_p commented on 2022-03-12 19:04 (UTC)

@LennyLennington Thanks, re-cloning the repo worked... but it defeats the simplicity provided by git of fetching only the updates. I'll try to look into how to fix it in the near future, when I'll have time.

LennyLennington commented on 2022-03-12 18:49 (UTC)

@Ivan_p easiest way to fix that submodule error is to remove the cached sources by doing a fresh clone of the AUR repo (or if you use an AUR helper, remove the cache for this repo and it would do a fresh clone automatically next time you try to use the helper to build it).

ivan_p commented on 2022-03-12 18:42 (UTC)

The new build fails for me, with either pre-existing PolyMC subfolder or without one:

==> Starting prepare()...
fatal: remote error: upload-pack: not our ref 09ec1d10c6d627f895109b21728dda000cbfa7d1
Fetched in submodule path 'libraries/quazip', but it did not contain 09ec1d10c6d627f895109b21728dda000cbfa7d1. Direct fetching of that commit failed.
==> ERROR: A failure occurred in prepare().
    Aborting...

LennyLennington commented on 2022-03-12 18:16 (UTC) (edited on 2022-03-12 18:16 (UTC) by LennyLennington)

Btw you should have set pkgrel back to 1 when you updated the version (too late now but if you're updating the version next time set pkgrel to 1).

Also, did you test that it builds and packages properly before you pushed the commit that changes it to 1.1.0? Because I had to push a patch to make it use the proper CMake flags and not attempt to install nonexistent files.

LennyLennington commented on 2022-03-12 18:01 (UTC)

Thank you