| Git Clone URL: | https://aur.archlinux.org/wlroots-git.git (read-only, click to copy) |
|---|---|
| Package Base: | wlroots-git |
| Description: | Modular Wayland compositor library (git development version) |
| Upstream URL: | https://gitlab.freedesktop.org/wlroots/wlroots |
| Keywords: | compositor egl gles2 libdrm libinput library modular opengl vulkan wayland wlroots |
| Licenses: | MIT |
| Provides: | libwlroots-0.19.so |
| Submitter: | aperez |
| Maintainer: | aperez (GreyXor) |
| Last Packager: | GreyXor |
| Votes: | 64 |
| Popularity: | 0.55 |
| First Submitted: | 2018-02-20 16:48 (UTC) |
| Last Updated: | 2024-07-14 10:33 (UTC) |
@shoober420:
the wlroots-git examples optionally depend on libavutil, libavodec, and libavformat, provided by ffmpeg.
The examples seem to be built by this PKGBUILD, but are not installed anyway, so by just setting -Dexamples=false in the PKGBUILD this would not need a dependency on ffmpeg.
If the examples aren't part of the package, not building them seems to be a good idea anyway.
This package requires “ffmpeg” to compile, please add to “makedepends=“.
Could the xorg-server-xwayland package be either added as a dependency or at least an optional dependency?
@Rucikir:
The real reason for your problem:
Archlinux just updated json-c from 0.13 to 0.14, which included an ABI break, meaning apps using libjson-c need to be recompiled. In order to not get weird crashes it is standard practice to change the so-called SONAME of a library when this happens so it just says "libjson-c.so.4 not found" instead of crashing somewhere. The new library is called "libjson-c.so.5", recompiling should fix it.
TL;DR: recompile sway, that should fix it
I got an error from the sway binary after updating wlroots for a missing libjson-c.so4 library. Is it a new dependency?
@Fedi265 @chron: Thanks for all the discussion, I have pushed an update to have options=(debug) now.
(bump to enable notifications for me since I forgot in the last comment)
@aperez: I don't particularly care wether debug is part of wlroot's options array; it's just that overriding strip to off breaks the debug info in the package for people who clean their source directories after building.
@chron: I can understand why options=(debug) would make sense. You might want a development package like wlroots-git to be built with debug info even if other packages on the system aren't, in order to get more useful bug reports by people using wlroots-git.
TL;DR:
for me, options=(debug) or options=() would be acceptable. It's just the !strip that's bothering me.
options=(debug strip) would probably offend people who don't like the -debug extra packages for some reason. (e.g. tooling support is lacking; yay doesn't install -debug packages generated by makepkg by default)
@aperez: No, I think he ment you should use debug and strip or remove options=() entirely/leave it empty.
I think you shouldn't overwrite a users /etc/makepkg.conf defaults, if they need either !strip or debug they can add the options themself.
@Ferdi265: So what you would suggest? If I understand your reasoning correctly, you would like to have options=(debug) in the PKGBUILD, so each user can decide choose to use strip or !strip. Isn't it?
Pinned Comments
aperez commented on 2018-09-28 08:31 (UTC) (edited on 2019-03-07 16:25 (UTC) by aperez)
IMPORTANT
Please do not flag this package as out-of-date if the only change you need is to update to a newer version. It is not needed because it always fetches the sources using Git and uses the most recent version without needing to modify the PKGBUILD — just rebuild the package.
Also, please try building in a clean chroot before assuming that the PKGBUILD is broken.